collectors: add startup time metrics #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djkazic
force-pushed
the
startup-time-monitoring
branch
from
66eba87
to
aba3709
Compare
calvinrzachman
approved these changes
Jun 26, 2024
Roasbeef
reviewed
Jun 26, 2024
djkazic
force-pushed
the
startup-time-monitoring
branch
4 times, most recently
from
7d39d0d
to
bac6bda
Compare
|
lndmon is now tolerant of LND not being unlocked yet. |
djkazic
force-pushed
the
startup-time-monitoring
branch
from
bac6bda
to
373684e
Compare
djkazic
force-pushed
the
startup-time-monitoring
branch
from
662e605
to
ca3c37f
Compare
djkazic
changed the title
|
@djkazic, remember to re-request review from reviewers when ready |
Roasbeef
requested changes
Jul 18, 2024
|
Will address comments tomorrow 👍🏻 but yep I can defo refactor |
djkazic
force-pushed
the
startup-time-monitoring
branch
from
ca3c37f
to
a7d400b
Compare
djkazic
force-pushed
the
startup-time-monitoring
branch
from
a7d400b
to
5544239
Compare
Roasbeef
approved these changes
Jul 23, 2024
| func (s *StateCollector) monitorStateChanges() { | ||
| var serverActiveReached bool | ||
|
|
||
| stateUpdates, errChan, err := s.lnd.State.SubscribeState(context.Background()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we don't track LND startup time. This modification records a start and end time for state transitions from RPC_ACTIVE to SERVER_ACTIVE (the bulk of startup time), then makes a prometheus gauge metric which will get picked up on the next scrape.
Edit: it would probably be helpful to make lndmon itself state-aware and not try to do any other scrapes until we see SERVER_ACTIVE.